search

conda-forge / cramjam-feedstock

A conda-smithy repository for cramjam.
BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

Rebuild for python 3.13 #39

Closed regro-cf-autotick-bot closed 1 month ago

regro-cf-autotick-bot commented 2 months ago

This PR has been triggered in an effort to update python313.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

bgruening commented 1 month ago

error: the configured Python interpreter version (3.13) is newer than PyO3's maximum supported version (3.12)

milesgranger commented 1 month ago

@bgruening Have you seen any projects successfully re-using wheels from PyPI? I have Python 3.13 support released here https://pypi.org/project/cramjam/2.8.4rc3/#files.

cramjam has zero python dependencies; and it's tiresome to try and maintain two separate full-build CI pipelines for reasons I'm not yet convinced of. It makes sense to have a native conda build if a project has multiple dependencies, but not when it's standalone like this, IMO.

martindurant commented 1 month ago

conda-build does support direct install of wheels: https://docs.conda.io/projects/conda-build/en/latest/user-guide/wheel-files.html#building-a-conda-package-from-a-wheel-file

Is it a conda-forge policy still to prevent this from happening? I can imagine it being an impediment, for example with 3.13 versus 3.13 free-thread builds (I assume these would need to be different somehow).

xhochy commented 1 month ago

conda-forge also uses different compilers and compiler flags that what is used for manylinux wheels. It is OK to rebuild from wheels if you cannot get the build to work, but this is a straight-forward recipe and and thus I don't think it is reasonable to install from the wheel.

martindurant commented 1 month ago

For reference, here is the anaconda defaults recipe for this package, which is tracking this repo but I think has some differences: https://github.com/AnacondaRecipes/cramjam-feedstock/blob/main/recipe/meta.yaml

xhochy commented 1 month ago

I posted a cleanup here which should simplify maintenance: https://github.com/conda-forge/cramjam-feedstock/pull/41 Most of the additional things here were needed as this was one of the earlier cross-compiled packages.

regro-cf-autotick-bot commented 1 month ago

I see that this PR has conflicts, and I'm the only committer. I'm going to close this PR and will make another one as appropriate. This was generated by https://github.com/regro/cf-scripts/actions/runs/10785748342 - please use this URL for debugging,