conda-forge / cryptominisat-feedstock

A conda-smithy repository for cryptominisat.
BSD 3-Clause "New" or "Revised" License
0 stars 7 forks source link

Rebuild for boost-cpp-1.70.0 #19

Closed regro-cf-autotick-bot closed 5 years ago

regro-cf-autotick-bot commented 5 years ago

This PR has been triggered in an effort to update boost-cpp-1.70.0.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed. Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues!

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mariusvniekerk commented 5 years ago

@conda-forge-admin please rerender

msoos commented 5 years ago

@conda-forge-admin please rerender

mariusvniekerk commented 5 years ago

@conda-forge-admin please rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

msoos commented 5 years ago

OK, only fails on liking boost to the main executable. Library is perfectly built. Python module is also perfectly built. Only issue is linking the main "cryptominisat5" executable, as it needs boost.

The issue is during configuration:

2019-06-11T19:46:58.9096636Z -- Found Boost 1.70.0 at $PREFIX/lib/cmake/Boost-1.70.0
2019-06-11T19:46:58.9098151Z --   Requested configuration: QUIET COMPONENTS program_options
2019-06-11T19:46:58.9110486Z -- Found boost_headers 1.70.0 at $PREFIX/lib/cmake/boost_headers-1.70.0
2019-06-11T19:46:58.9124426Z -- Found boost_program_options 1.70.0 at $PREFIX/lib/cmake/boost_program_options-1.70.0
2019-06-11T19:46:58.9135448Z --   libboost_program_options.so.1.70.0
2019-06-11T19:46:58.9137632Z -- Adding boost_program_options dependencies: headers
2019-06-11T19:46:58.9146884Z -- Boost 1.46 found.
2019-06-11T19:46:58.9147898Z -- Found Boost components:
2019-06-11T19:46:58.9150058Z    program_options

It seems to look for and find Boost twice? The second time probably messes things up and throws everything off. The first finding is correct and should stay. I'll look into it.

mariusvniekerk commented 5 years ago

@ocefpaf is this one of those cmake finding a dumb boost?

msoos commented 5 years ago

Both 1.46 and 1.70 should work. I don't quite understand this whole auto-update thing of conda at all. It work with 1.46... So 1.46 is not dumb I guess? But having 2 is definitely confusing :S

kmuehlbauer commented 5 years ago

See https://github.com/conda-forge/boost-cpp-feedstock/issues/48 and this comment: https://gitter.im/conda-forge/conda-forge.github.io?at=5d0be674e7267a62a90e624e

ocefpaf commented 5 years ago

@ocefpaf is this one of those cmake finding a dumb boost?

Yep. As @kmuehlbauer mentioned above the -DBoost_NO_BOOST_CMAKE=ON option is better than my attempt to patch it. Looks like it is passing here. I'll check the other failing feedstocks today.

msoos commented 5 years ago

Thanks!