ENH use new sysroot - Githubissues

conda-forge / ctng-compiler-activation-feedstock

A conda-smithy repository for ctng-compiler-activation.

BSD 3-Clause "New" or "Revised" License

13 stars 22 forks source link

ENH use new sysroot #24

Closed beckermr closed 4 years ago

beckermr commented 4 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

beckermr commented 4 years ago

@conda-forge-admin rerender

beckermr commented 4 years ago

@isuruf @jjhelmus I do not know what to do about this block in the conda_build_config.yaml

FINAL_CONDA_PYTHON_SYSCONFIGDATA_NAME:
  - _sysconfigdata_x86_64_conda_cos6_linux_gnu   # [linux64]
  - _sysconfigdata_i686_conda_cos6_linux_gnu   # [linux32]
  - _sysconfigdata_powerpc64le_conda_cos7_linux_gnu  # [ppc64le]
  - _sysconfigdata_aarch64_conda_cos7_linux_gnu  # [aarch64]

Do I need it to point to the new sysroot?

beckermr commented 4 years ago

@conda-forge-admin rerender

isuruf commented 4 years ago

For the python sysconfigdata thing, we can keep it as it is now. We should add a -conda- to python-feedstock as well and then fix it here.

beckermr commented 4 years ago

ok @isuruf, ready to merge?

beckermr commented 4 years ago

Not today but yes.