Fix non-POSIX activation/deactivation scripts.

conda-forge / ctng-compiler-activation-feedstock

A conda-smithy repository for ctng-compiler-activation.

BSD 3-Clause "New" or "Revised" License

13 stars 22 forks source link

Fix non-POSIX activation/deactivation scripts. #59

Closed ktlim closed 2 years ago

ktlim commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

These scripts are sourced from the shell hook during conda activation, so they need to run under any shell supported by that hook. The shebang line is ignored when a script is sourced and not executed with exec().

In particular, these scripts fail under dash, which is the default /bin/sh under Ubuntu 20.04 LTS.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

ktlim commented 2 years ago

No idea what's going on with the linter. I'll leave that for the experts...

beckermr commented 2 years ago

@conda-forge-admin relint

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

beckermr commented 2 years ago

@conda-forge-admin relint

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

beckermr commented 2 years ago

The linting passes locally but our web server is reporting

LINTING ERROR: 'CommentedSeq' object has no attribute 'get'

beckermr commented 2 years ago

@conda-forge-admin relint

beckermr commented 2 years ago

@conda-forge-admin relint

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

beckermr commented 2 years ago

@conda-forge-admin relint

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.