ENH get close to POSIX again - Githubissues

conda-forge / ctng-compiler-activation-feedstock

A conda-smithy repository for ctng-compiler-activation.

BSD 3-Clause "New" or "Revised" License

13 stars 22 forks source link

ENH get close to POSIX again #61

Closed beckermr closed 2 years ago

beckermr commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

closes #41

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

beckermr commented 2 years ago

@conda-forge-admin rerender

beckermr commented 2 years ago

@conda-forge-admin rerender

beckermr commented 2 years ago

@ktlim @mbargull @isuruf Can you all take a close look at this PR?

ktlim commented 2 years ago

I can confirm that all activate/deactivate scripts source without syntax errors on dash. I have not checked functionality.

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/ctng-compiler-activation-feedstock/actions/runs/1654774570.

beckermr commented 2 years ago

I tested this PR on a zsh shell on linux and it works great. Any other comments @jakirkham @isuruf @mbargull or shall we merge?

jakirkham commented 2 years ago

Would defer to Isuru

beckermr commented 2 years ago

OK. I'm gonna merge this. If stuff breaks we can mark the builds broken later.