conda-forge / ctng-compiler-activation-feedstock

A conda-smithy repository for ctng-compiler-activation.
BSD 3-Clause "New" or "Revised" License
13 stars 22 forks source link

Add flags to avoid string optimization #66

Closed hmaarrfk closed 1 year ago

hmaarrfk commented 2 years ago

Fixes: https://github.com/conda-forge/ctng-compiler-activation-feedstock/issues/63

Questions:

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 2 years ago

@conda-forge-admin, please rerender

beckermr commented 2 years ago

I can't recall if cflags gets reused for the other vars and so we only need this there.

I think @isuruf might have insight or we can consult the activation scripts.

hmaarrfk commented 2 years ago

A quick search of CFLAGS in https://github.com/hmaarrfk/ctng-compiler-activation-feedstock/blob/fno-merge-constants/recipe/activate-gfortran.sh#L88 reveals nothing.

beckermr commented 2 years ago

Right except that the Fortean compiler requires the c one maybe. In any case, duplicated flags are ugly but shouldn’t break anything I think.