ENH prefix flags from env

conda-forge / ctng-compiler-activation-feedstock

A conda-smithy repository for ctng-compiler-activation.

BSD 3-Clause "New" or "Revised" License

13 stars 22 forks source link

ENH prefix flags from env #67

Closed beckermr closed 2 years ago

beckermr commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

closes #7

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

beckermr commented 2 years ago

@conda-forge-admin rerender

beckermr commented 2 years ago

@conda-forge-admin rerender

beckermr commented 2 years ago

ok @isuruf this one is ready for review!

isuruf commented 2 years ago

cc @katietz

isuruf commented 2 years ago

Thanks

xhochy commented 2 years ago

Somehow this broke the tensorflow builds, when I pin gcc_linux-64 to a previous build, everything works again. It is probably introducing somewhere an additional space or so. I'll investigate and update here.

xhochy commented 2 years ago

The issue is that we now have trailing whitespace or double whitespaces in these flags. I fixed this now via https://github.com/conda-forge/tensorflow-feedstock/pull/213/commits/701c1faa8a01674f283e9660cd18a16e98128fa3

beckermr commented 2 years ago

I'm happy to fix but idk a great bashism to prefix if a variable is not empty. I could use an if statement but that'd be horrible looking. Any ideas?