pitrou
commented
2 years ago Also cc @xhochy @h-vetinari @jakirkham as libprotobuf maintainers (since that package is affected).
Open pitrou opened 2 years ago
pitrou
commented
2 years ago Also cc @xhochy @h-vetinari @jakirkham as libprotobuf maintainers (since that package is affected).
xhochy
commented
2 years ago cc @conda-forge/libprotobuf
pitrou
commented
2 years ago I also reported the issue to the protobuf issue tracker: https://github.com/protocolbuffers/protobuf/issues/9947
xhochy
commented
2 years ago @pitrou Can you post the compiler error you get? I fail to build a minimal reproducible example and I also struggle to understand what could go wrong here.
pitrou
commented
2 years ago There is no compiler error. The error happens at runtime:
$ ./build-test/debug/arrow-flight-test
./build-test/debug/arrow-flight-test: symbol lookup error: /home/antoine/miniconda3/envs/pyarrow/lib/libarrow_flight.so.900: undefined symbol: _ZN6google8protobuf8internal16InternalMetadataD1Ev
$ c++filt _ZN6google8protobuf8internal16InternalMetadataD1Ev
google::protobuf::internal::InternalMetadata::~InternalMetadata()This should have been caught by the linker earlier. Also this would mean that you could not link against any destructor in a lib. The above code changes behaviour depending on the definitions but it doesn't change inline-vs-not-inline.
pitrou
commented
2 years ago The code does change inline-vs-not-inline (a member function which is defined inside the class body is implicitly inline).
xhochy
commented
2 years ago Ah, I implicitly read ~InternalMetadata() {}
xhochy
commented
2 years ago Keeping the discussion for now in the upstream Arrow issue until we fully understand what is going wrong here.
xhochy
commented
2 years ago Ok, here is a reproducer: https://gist.github.com/pitrou/1c892d1c42bd6ece9b68a9eb015b76c8
pitrou
commented
2 years ago https://github.com/protocolbuffers/protobuf/issues/9947 was closed as won't fix so this will have to be fixed on the conda-forge side.
jakirkham
commented
2 years ago Some packages need to tweak the compiler flags (for example). Would suggest just making this change in the feedstock for now
pitrou
commented
2 years ago Not wanting to put any pressure, but it would be nice to get this fixed at some point :-)
pitrou
commented
2 years ago Finally, a fix was accepted for https://github.com/protocolbuffers/protobuf/issues/9947 and should be in the upcoming protobuf 21.3.
Solution to issue cannot be found in the documentation.
Issue
The
-fvisibility-inlines-hiddencompiler option is described thusly in the GCC wiki:This looks theoretically harmless, except that whether class member are defined inline may depend on exact compilation options.
One typical example is when a function declaration depends on whether
NDEBUGis enabled. This is exactly what libprotobuf 3.20.1 does (but not 3.19.4):What happens is then:
NDEBUGdefined (release mode), so~InternalMetadata, being inlined, isn't exported bylibprotobuf.soNDEBUGnot defined), expects to find the~InternalMetadatainlibprotobuf.so, and failsInstalled packages
Environment info