conda-forge / ctng-compiler-activation-feedstock

A conda-smithy repository for ctng-compiler-activation.
BSD 3-Clause "New" or "Revised" License
13 stars 23 forks source link

Define -DPython_FIND_VIRTUALENV=First in CMAKE_ARGS #99

Closed hmaarrfk closed 1 year ago

hmaarrfk commented 1 year ago

Comment:

Would it make sense to define this?

it seemed that defining Pythin_FIND_VIRTUALENV helped in

https://github.com/conda-forge/openimageio-feedstock/pull/87

https://cmake.org/cmake/help/latest/module/FindPython.html

cc: @h-vetinari

isuruf commented 1 year ago

You should set Python3_FIND_STRATEGY=LOCATION. This is done by many feedstocks and I think it's somewhere in our docs.

isuruf commented 1 year ago

And also patch upstream projects to use https://cmake.org/cmake/help/latest/policy/CMP0094.html#policy:CMP0094

hmaarrfk commented 1 year ago

thanks

hmaarrfk commented 1 year ago

Reading this section was helpful to me: https://cmake.org/cmake/help/latest/manual/cmake-policies.7.html#introduction