Update to gcc 13.2.0 -- Needed for Ubuntu 23.10

conda-forge / ctng-compilers-feedstock

A conda-smithy repository for ctng-compilers.

BSD 3-Clause "New" or "Revised" License

12 stars 25 forks source link

Update to gcc 13.2.0 -- Needed for Ubuntu 23.10 #113

Closed hmaarrfk closed 10 months ago

hmaarrfk commented 10 months ago

See https://gcc.gnu.org/gcc-13/

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 10 months ago

I feel like I'm hitting a repeat of https://github.com/conda-forge/ctng-compilers-feedstock/issues/95 for ubuntu 23.10

hmaarrfk commented 10 months ago

Ummmm:

For C++, construction of the global iostream objects std::cout, std::cin, etc. is now done inside the standard library, instead of in every source file that includes the header. This change improves the start-up performance of C++ programs, but it means that code compiled with GCC 13.1 will crash if the correct version of libstdc++.so is not used at runtime. See the documentation about using the right libstdc++.so at runtime. Future GCC releases will mitigate the problem so that the program cannot be run at all with an older libstdc++.so.

Really not sure what to do about this. @h-vetinari has anything been using GCC 13 for now?

hmaarrfk commented 10 months ago

I can confirm that this helps get thigns working for ubuntu 23.10

hmaarrfk commented 10 months ago

thank you!

h-vetinari commented 10 months ago

This change improves the start-up performance of C++ programs, but it means that code compiled with GCC 13.1 will crash if the correct version of libstdc++.so is not used at runtime.

This is pretty wild IMO, but luckily it seems that zero feedstocks are using GCC 13 so far.

hmaarrfk commented 10 months ago

it seems that this note was present even in GCC 13.1. I believe maybe it is warning users that they must use libstdc++ built with 13+ or else face serious consequences.

I think we do that at conda forge right?

isuruf commented 10 months ago

Shouldn't be a problem for us

hmaarrfk commented 10 months ago

Thanks for confirming!