ENH build 9.3.0 - Githubissues

conda-forge / ctng-compilers-feedstock

A conda-smithy repository for ctng-compilers.

BSD 3-Clause "New" or "Revised" License

12 stars 28 forks source link

ENH build 9.3.0 #34

Closed beckermr closed 4 years ago

beckermr commented 4 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The home item is expected in the about section.
The license item is expected in the about section.
The summary item is expected in the about section.
The outputs section contained an unexpected subsection name. target is not a valid subsection name.
The outputs section contained an unexpected subsection name. target is not a valid subsection name.
The outputs section contained an unexpected subsection name. target is not a valid subsection name.
The outputs section contained an unexpected subsection name. target is not a valid subsection name.

beckermr commented 4 years ago

@conda-forge-admin rerender

beckermr commented 4 years ago

any ideas here @isuruf? It looks like the patches don't apply correctly for gcc 9.3.0.

beckermr commented 4 years ago

OK @isuruf. It appears this works! I think we can ship 9.3.0 on all platforms too

I have submitted the patched patch here: https://github.com/conda-forge/crosstool-ng/pull/1

I guess we should merge that, rebuild crosstool-ng, and then remove the patched patch here and build again?

beckermr commented 4 years ago

We might as well ship the compilers while we are here too maybe.

isuruf commented 4 years ago

Can you send a PR to crosstool-ng-feedstock ?

beckermr commented 4 years ago

Yup, will do!

beckermr commented 4 years ago

done: https://github.com/conda-forge/crosstool-ng-feedstock/pull/14

beckermr commented 4 years ago

This needs to be merged to a new branch upstream - getting these changes on the other 9 branch is huge pain due to conflicts.

beckermr commented 4 years ago

The skips should already be in this pr. I'll bump the build number.

isuruf commented 4 years ago

No, I mean, shall we remove the skips?

beckermr commented 4 years ago

Ohhh. We can do that. I don't think builds will pick up the compilers due to the pinnings. I'm out and about now but I'll try later.

beckermr commented 4 years ago

@conda-forge-admin rerender

beckermr commented 4 years ago

I guess if we are building everything this PR can go into master.

beckermr commented 4 years ago

@isuruf This one is ready to merge. IDK if we should push to master or maybe a new 9.x branch. Moving the global pins would be fine for everything except gfortran which needs a migration iiuic. So given that we might want to maintain the older versions for a while, a 9.x branch might be more sensible. What do you think?

beckermr commented 4 years ago

@conda-forge-admin rerender

beckermr commented 4 years ago

Two compiler builds at once is killing travis and drone. I am going to merge and then if they don't run, that's fine too. We only really need the libraries for 9.3 on x86_64. If we get the others, that's great, but NBD if not.