Make sure libstdc++ is not linked to accidentally

conda-forge / ctng-compilers-feedstock

A conda-smithy repository for ctng-compilers.

BSD 3-Clause "New" or "Revised" License

12 stars 28 forks source link

Closed isuruf closed 3 years ago

isuruf commented 3 years ago

Some brain-dead build systems don't use LDFLAGS and might accidentally link to libstdc++.a. Make sure there's a libstdc++.so living right next to it.

cc @183amir

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

183amir commented 3 years ago

Thanks a lot for this. It fixed our issue.

Some brain-dead build systems don't use LDFLAGS

Is that setuptools? How can we fix this?

isuruf commented 3 years ago

Is that setuptools? How can we fix this?

It's libblitz's build system. It doesn't use LDFLAGS as it is supposed to.