Patch GNU openmp to be fork safe

conda-forge / ctng-compilers-feedstock

A conda-smithy repository for ctng-compilers.

BSD 3-Clause "New" or "Revised" License

12 stars 28 forks source link

Patch GNU openmp to be fork safe #8

Closed davidbrochart closed 4 years ago

davidbrochart commented 4 years ago

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The home item is expected in the about section.
The license item is expected in the about section.
The summary item is expected in the about section.
The outputs section contained an unexpected subsection name. target is not a valid subsection name.
The outputs section contained an unexpected subsection name. target is not a valid subsection name.
The outputs section contained an unexpected subsection name. target is not a valid subsection name.

davidbrochart commented 4 years ago

@beckermr I inserted a syntax error in the patch file. I can see the patch is applied but obviously too late because it doesn't fail. Where should it be applied?

isuruf commented 4 years ago

Patches should go in crosstool-ng. https://github.com/conda-forge/crosstool-ng-feedstock uses https://github.com/ContinuumIO/crosstool-ng and a patch for gcc 7.3.0 should go in https://github.com/ContinuumIO/crosstool-ng/tree/master/packages/gcc/7.3.0

beckermr commented 4 years ago

Got it @isuruf. I am still strongly not in favor of merging this into the main conda-forge compilers unless we use the version that is finally accepted upstream.

davidbrochart commented 4 years ago

@beckermr I know but the original author of the patch doesn't have time to spend on it any more, and he's much more qualified than me to try and push it upstream.

beckermr commented 4 years ago

Then I think we have to wait. OpenMP is a core standard used by tons of projects. We simply cannot potentially ship a buggy OpenMP implementation.

davidbrochart commented 4 years ago

Sure, putting that on hold then.