Make `noarch` - Githubissues

conda-forge / cuda-feedstock

A conda-smithy repository for cuda.

BSD 3-Clause "New" or "Revised" License

2 stars 9 forks source link

Make `noarch` #7

Closed adibbley closed 1 year ago

adibbley commented 1 year ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Fixes #4 Fixes #1

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

adibbley commented 1 year ago

@conda-forge-admin, please rerender

adibbley commented 1 year ago

@conda-forge-admin , please restart ci

jakirkham commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!

leofang commented 1 year ago

Q: shouldn't we bump the build num?

jakirkham commented 1 year ago

That's a fair point Leo. Went ahead and pushed a build/number bump to main and cross-linked the PR in the commit message. Repeated this for the other noarch PRs

That said, since we are publishing a different architecture than the ones we already published, the packages will still upload. Users will still be able to download and install them (especially for the previously unsupported platforms)

Though Conda does sometimes issue warnings when downgrading or keeping the same build/number. So it is better to avoid the warning, which the new packages should do