conda-forge / cuda-nvcc-feedstock

A conda-smithy repository for cuda-nvcc.
BSD 3-Clause "New" or "Revised" License
1 stars 11 forks source link

Check for existing `-ccbin` / `--compiler-bindir` flag in `NVCC_PREPEND_FLAGS` #20

Open jakirkham opened 1 year ago

jakirkham commented 1 year ago

As a user can include their own -ccbin / --compiler-bindir flags that would conflict with our flags added to NVCC_PREPEND_FLAGS (see below), it would be good to add a check to only add our flags if they are not -ccbin / --compiler-bindir in NVCC_PREPEND_FLAGS

https://github.com/conda-forge/cuda-nvcc-feedstock/blob/f602ed9c9566326d6f2effdfb0a3b80cff3661a7/recipe/activate.sh#L38

In the nvcc wrapper script, this was handled on this line. Though --compiler-bindir is not checked. So maybe that logic can be adapted and tweaked here.

Edit: Originally came up in PR ( https://github.com/conda-forge/gromacs-feedstock/pull/17 )