search

conda-forge / cuda-nvcc-feedstock

A conda-smithy repository for cuda-nvcc.
BSD 3-Clause "New" or "Revised" License
1 stars 11 forks source link

Activation.bat/activation.sh differences #47

Open baszalmstra opened 1 month ago

baszalmstra commented 1 month ago

https://github.com/conda-forge/cuda-nvcc-feedstock/blob/ce7738ef7c5019a7875e1829649c0fc1d6bd3581/recipe/activate.sh#L9-L60

I just noticed that this code is not present in the Windows activation scripts. Is this on purpose or just an oversight?

Should I add it?

leofang commented 1 month ago

IIRC this was to reflect that fact that we have targets subdir on Linux (to support cross compilation) but not on Windows. Did you run into any issue because of the asymmetry?

baszalmstra commented 1 month ago

Yes, I'm trying to build pytorch on windows. The issue I'm running into is that the cuda build fails because crt/host_config.h could not be found. This file is provided by nvcc (and later the crt-dev package), however, these packages are usually installed in the build section of the recipe. The Library/include directory of the build environment is not added as an include directory. Since the crt/host_config.h file on linux is included in the targets subdirectory I assume similar logic should be applied for the windows package. Did I misunderstand?

leofang commented 1 month ago

Indeed, now that I look at it closer, it does seem like an oversight that on Windows we missed to add both build and host include paths to the activation script, as done in the Linux counterpart. @conda-forge/cuda can anyone double confirm ?