conda-forge / cuda-nvcc-impl-feedstock

A conda-smithy repository for cuda-nvcc-impl.
BSD 3-Clause "New" or "Revised" License
1 stars 10 forks source link

Update for CUDA12.6.0 #24

Closed adibbley closed 2 months ago

adibbley commented 2 months ago

xref:

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

adibbley commented 2 months ago

@conda-forge-admin, please restart ci

adibbley commented 2 months ago

@conda-forge-admin, please restart ci

adibbley commented 2 months ago

@conda-forge-admin, please lint

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

jakirkham commented 2 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-nvcc-impl-feedstock/actions/runs/10220814745.

adibbley commented 2 months ago

I've been hitting that rerender error as well, doing it locally does work though.

jakirkham commented 2 months ago

The re-rendering is complaining it did not know how to define platform in this block

https://github.com/conda-forge/cuda-nvcc-impl-feedstock/blob/938b371b79b824c439485ac52b29553444d31835/recipe/meta.yaml#L7-L9

jakirkham commented 2 months ago

What version of conda-build do you have locally?

adibbley commented 2 months ago

24.5.0

jakirkham commented 2 months ago

Ok so maybe this is a bug with the recently released conda-build version 24.7.1: https://github.com/conda-forge/conda-build-feedstock/pull/229

Edit: Interesting that building the package doesn't run into this issue. Must have something to do with where conda-smithy hooks into conda-build

jakirkham commented 2 months ago

Just to confirm, are you using conda-smithy version 3.37.2?

adibbley commented 2 months ago

Yes

adibbley commented 2 months ago

Pulled your changes and local rerender had no further changes, adding automerge. Thanks John!

github-actions[bot] commented 2 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

jakirkham commented 2 months ago

Regarding the re-rendering issue, filed upstream issue: https://github.com/conda-forge/conda-smithy/issues/2011