conda-forge / cuda-nvtx-feedstock

A conda-smithy repository for cuda-nvtx.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

Migrate to `{{ stdlib("c") }}` #13

Closed hcho3 closed 6 months ago

hcho3 commented 7 months ago

The sysroot* syntax is getting phased out (https://github.com/conda-forge/conda-forge.github.io/issues/2102). The recommendation is to move to {{ stdlib("c") }}.

Ref https://github.com/conda-forge/cuda-feedstock/issues/26

conda-forge-webservices[bot] commented 7 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 6 months ago

@conda-forge-admin , please re-render

jakirkham commented 6 months ago

@conda-forge-admin , please restart CI

jakirkham commented 6 months ago

@conda-forge-admin , please re-render

jakirkham commented 6 months ago

@conda-forge-admin , please re-render

jakirkham commented 6 months ago

Interesting apparently the bot had a no change commit: https://github.com/conda-forge/cuda-nvtx-feedstock/pull/13/commits/0228ab7defdcbf4f9f4d4331ce458ee024d3eb1b

According to the GHA job, some changes were made:

[stdlib-migration 3dfa8c6] MNT: Re-rendered with conda-build 24.5.0, conda-smithy 3.35.1, and conda-forge-pinning 2024.05.14.14.54.30
 1 file changed, 2 deletions(-)
INFO:conda_smithy.configure_feedstock:
INFO:conda_smithy.configure_feedstock:These changes need to be pushed to github!

[stdlib-migration 0228ab7] MNT: Re-rendered with conda-build 24.5.0, conda-smithy 3.35.1, and conda-forge-pinning 2024.05.14.14.54.30
 Date: Tue May 14 21:28:01 2024 +0000
jakirkham commented 6 months ago

Testing locally, conda-smithy appears to be applying these changes ( https://github.com/conda-forge/conda-smithy/pull/1923 ) to the GHA automerge workflow as expected

Guessing this is just a bug with the re-rendering bot. Filed upstream in issue: https://github.com/conda-forge/conda-forge-webservices/issues/706

jakirkham commented 6 months ago

Seeing a new issue with the Windows build on CI (also attached log for posterity):

Traceback (most recent call last):
  File "C:\Miniforge\Scripts\conda-build-script.py", line 10, in <module>
    sys.exit(execute())
  File "C:\Miniforge\lib\site-packages\conda_build\cli\main_build.py", line 590, in execute
    api.build(
  File "C:\Miniforge\lib\site-packages\conda_build\api.py", line 250, in build
    return build_tree(
  File "C:\Miniforge\lib\site-packages\conda_build\build.py", line 3638, in build_tree
    packages_from_this = build(
  File "C:\Miniforge\lib\site-packages\conda_build\build.py", line 2696, in build
    output_d["files"] = set(output_d["files"]) - to_remove
TypeError: 'frozendict.frozendict' object does not support item assignment

Looks potentially related to an upstream change: https://github.com/conda/conda-build/pull/5284

jakirkham commented 6 months ago

Reproduced independently of these changes in PR ( https://github.com/conda-forge/cuda-nvtx-feedstock/pull/16 ). Have summarized the results in comment ( https://github.com/conda-forge/cuda-nvtx-feedstock/pull/16#issuecomment-2111240599 ). Also raised as upstream issue ( https://github.com/conda/conda-build/issues/5342 )

jakirkham commented 6 months ago

@conda-forge-admin , please re-render

jakirkham commented 6 months ago

To bring CI back into a working state, have pinned to conda-build version 24.3.0 in PR: https://github.com/conda-forge/cuda-nvtx-feedstock/pull/17

Squashed and rebased the changes here. Plus cleaned out any workaround that were attempted

Asked the bot to do a fresh re-render, which it did

Think that should clear up the CI issues we have seen before so that we can merge this

github-actions[bot] commented 6 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

jakirkham commented 6 months ago

@conda-forge-admin , please re-render

github-actions[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-nvtx-feedstock/actions/runs/9087714664.