conda-forge / cudnn-feedstock

A conda-smithy repository for cudnn.
BSD 3-Clause "New" or "Revised" License
3 stars 16 forks source link

Update the recipe url to the new format #55

Open leofang opened 1 year ago

leofang commented 1 year ago

The recipe should be updated to follow the template form as in cuTENSOR/cuSPARSELt:

This would allow the CF bot to pick up the new updates from NVIDIA and send a version update PR to here automatically.

leofang commented 1 year ago

This is done in #56.

leofang commented 1 year ago

I was wondering why this feedstock remains silent since #56... There are a few newer versions already, but the bot didn't send any update.

It turns out the cuDNN team uses a wrong format in the json file (the package build number is mistakenly included in the json filename) and we have no way to check it. It was already raised by another internal team: nvbugs 4056484

leofang commented 1 year ago

By json files I refer to those under https://developer.download.nvidia.com/compute/cudnn/redist/.

jakirkham commented 1 year ago

Is it worth raising as an upstream issue?

jakirkham commented 8 months ago

Tried requesting a bot update ( https://github.com/conda-forge/cudnn-feedstock/issues/74 ) to see what would happen, it opened PR ( https://github.com/conda-forge/cudnn-feedstock/pull/75 ) and promptly failed. Details about the failure in this comment: https://github.com/conda-forge/cudnn-feedstock/pull/75#issuecomment-1940402974

Think cuda_major is confusing for the bot. Though there may not be enough information for the bot to go off of either

https://github.com/conda-forge/cudnn-feedstock/blob/34726d4838930721ac980ef1119f4e082c99075b/recipe/meta.yaml#L2

Edit: The bot is also pinning to CUDA 11.0 ( https://github.com/conda-forge/cudnn-feedstock/pull/75#issuecomment-1940425944 ), which causes issues

jakirkham commented 8 months ago

Did spot one issue: https://github.com/conda-forge/cudnn-feedstock/issues/76

Fixing with PR: https://github.com/conda-forge/cudnn-feedstock/pull/77

Not sure if that is enough to fix this issue, but we can test after that lands

jakirkham commented 8 months ago

The above PR was merged

Tried a fresh version update: https://github.com/conda-forge/cudnn-feedstock/pull/79

Though am still seeing issues with the update. Looks like it may be a different issue though. It is no longer running into issues with cuda_major, but it still doesn't know how to handle CUDA 11 & 12

Edit: More details in this comment: https://github.com/conda-forge/cudnn-feedstock/pull/79#issuecomment-1940938670