conda-forge / cupy-feedstock

A conda-smithy repository for cupy.
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

Rebuild for python38 #10

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 4 years ago

This PR has been triggered in an effort to update python38.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed. Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children: rift And potentially more. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/11874, please use this URL for debugging

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 4 years ago

Let us hold off for a while. Conda-forge's SciPy is not ready yet:

$ conda create -n PY38 python=3.8 numpy scipy cython fastrlock
Collecting package metadata: done
Solving environment: failed

UnsatisfiableError: The following specifications were found to be in conflict:
  - python=3.8
  - scipy -> python[version='>=3.7,<3.8.0a0']
Use "conda search <package> --info" to see the dependencies for each package.

so we won't be able to test the cupyx.scipy module in a conda PY38 environment.

leofang commented 4 years ago

Update: a scipy package for PY38 just came out two days ago!

jakirkham commented 4 years ago

Are you saying we should click the big green button? πŸ˜„

leofang commented 4 years ago

The worst-case scenario is a crappy package that can be manually removed later? I don't see why not 🀣

We could also wait until an official CuPy+PY38 wheel is uploaded to PyPI.

jakirkham commented 4 years ago

Yep, pretty much. Also ok waiting for the wheel. Happy to defer to others πŸ™‚

jakirkham commented 4 years ago

@leofang, how do you feel about merging? πŸ™‚

leofang commented 4 years ago

I want to ensure the recipe is up-to-date and pass CIs.

@conda-forge-admin, please rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.

leofang commented 4 years ago

@conda-forge-admin, please restart ci

leofang commented 4 years ago

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.

Pinging @jakirkham for further assistance πŸ˜†

leofang commented 4 years ago

@jakirkham CI tests are all passed. Not sure what the re-rendering error was, but otherwise it's good to go I think.

jakirkham commented 4 years ago

@kmaehashi, are you ok with us building Python 3.8 packages here?

leofang commented 4 years ago

Just curious if this would work now...

@conda-forge-admin, please rerender

leofang commented 4 years ago

Oh, nice! Rerendering works today πŸ˜†

jakirkham commented 4 years ago

Oh the bot may have been out-of-date. We looked into automating updates of the bot, but it is a bit tricky with CDN as we would have to trigger a rebuild of the bot with a delay. So someone needs to go somewhere and click a button manually to rebuild the bot manually. Looks like that has since happened. So we are good πŸ™‚

leofang commented 4 years ago

I don't think there's anything preventing us from making a PY38 package. If something goes wrong, we just roll back.

@conda-forge/cupy I plan to push the green button at 5pm EST, Nov 26, 2019. Let me know if you want to wait longer before that. Thanks.

jakirkham commented 4 years ago

Thanks @leofang! πŸ˜€