Avoid building from sdist

conda-forge / cupy-feedstock

A conda-smithy repository for cupy.

BSD 3-Clause "New" or "Revised" License

5 stars 23 forks source link

Avoid building from sdist #100

Closed leofang closed 3 years ago

leofang commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Fix #98.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

jakirkham commented 3 years ago

Another option might be to recythonize generating fresh C/C++ code (assuming I understand the upstream issue correctly, which I may not)

leofang commented 3 years ago

Another option might be to recythonize generating fresh C/C++ code (assuming I understand the upstream issue correctly, which I may not)

Yes that's right John, though it'd involve patching setup.py/cupy_setup_build.py to force cythonizing. Changing the source seems easier (all tests have passed).

jakirkham commented 3 years ago

I think there is a way to force cythonization, but yeah it's not always easy.