Closed conda-forge-admin closed 11 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/cupy-feedstock/actions/runs/6733459902.
@conda-forge-admin, please rerender
@conda-forge-admin, please rerender
It seems conda-smithy would ignore the local migrator if it's already included in the pinning feedstock. Changes made are either no effect or ruining everything. Let me prepare a new migrator..
@conda-forge-admin, please rerender
@conda-forge-admin, please rerender
@conda-forge-admin, please rerender
@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/cupy-feedstock/actions/runs/6734359406.
@jakirkham for some reason I can't convince conda-smithy to generate the Windows + CUDA 12 CI configs, am I missing something?
@conda-forge-admin, please rerender
OK use_local
was what I missed... Back to the game now.
@jakirkham @adibbley I hit this error
CUDA '12.0' is not supported
on Windows because of this line: https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/5406ead25c4d208b767ec5c893ec4642bf0a03eb/recipe/install_cuda.bat#L29
I think we need some extra logic applied to the ci-setup feedstock before I can even start doing experiments, would it be acceptable?
@conda-forge-admin , please re-render
Thanks Leo! 🙏
For reference am looking at this feature in conda-smithy
Am seeing this error (on CI):
Looks like we are missing cuda-profiler-api
, which is being worked on here: https://github.com/conda-forge/cuda-profiler-api-feedstock/pull/2
Also cuda-driver-dev
is Linux only (so will need to update the selectors on that)
@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/cupy-feedstock/actions/runs/6738536152.
I'll fix the build system patch to make it applicable to windows too.
@jakirkham is it expected that win + cuda 11 fails, because we hacked the ci-setup script?
My suggested plan:
Would prefer that we have a Windows + CUDA 12 migrator in place before we start merging feedstock PRs
@jakirkham Ah, yes. Could you plz review the migrator I added to this PR?
Thanks Leo! 🙏
Generally that seems reasonable
Am wondering if it would be preferable to roll the CUDA 12 Windows migrator in with the rest of the CUDA 12 migration to keep everything in sync. That way when the migrator is closed out, we can add CUDA 12 support across the board to conda-forge CUDA matrix (as opposed to only adding some OSes/architectures initially and then later adding others)
Tried the latter in PR ( https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5121 ). In attempting to re-render this PR with that migrator, everything seemed to work here as-is. Please see commit ( https://github.com/jakirkham-feedstocks/cupy-feedstock/commit/2d39557155d3177f3c68f487c2756850e665ddb9 ) for details
What do you think?
That sounds good, I actually did the unified migrator first, but back then I was confused by why the CI configs didn't show up after migration. Now that I understand / recall how things work, we can do that no problem.
One minor concern is that for feedstocks already migrated, they'd see another bot PR which could be confusing?
Yeah even with a new migrator, they would get a new PR
The bot isn't always smart enough to pick up on skip
s (so could wind up making some cosmetic changes like reordering conda-forge.yml
)
Did try to update the migrator PR title to draw attention to the addition of Windows
We could also mention this in the webpage repo issue as we did with ARM to help broadcast this a bit more
@conda-forge-admin , please re-render
Some of the Windows CUDA 12 jobs timed out when creating the .conda
package after the build. Going to try restarting them
@conda-forge-admin, please re-render
FWIW just testing to see that the conda-forge-ci-setup
changes are working as expected. So far so good
FWIW started PRs to update some dependencies for CUDA 12 Windows:
Let me apply the migrator here, wait for all dependencies to be ready, and then squash-merge.
@conda-forge-admin, please rerender
It'd take some time to get the CDN sync'd, given the cudnn PR just got merged (https://github.com/conda-forge/cudnn-feedstock/pull/66).
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day!
Close #205.
Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #205.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.