conda-forge / cupy-feedstock

A conda-smithy repository for cupy.
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

`%CUDA_PATH%` activation on Windows #232

Closed jakirkham closed 10 months ago

jakirkham commented 10 months ago

Currently on Windows we set %CUDA_PATH% to %CONDA_PREFIX%

https://github.com/conda-forge/cupy-feedstock/blob/11d783c60f134a359f8b617bf21cc748b8463c90/recipe/activate.bat#L10

However it appears when users run with this this, they get CUDA_PATH detection warnings. Though they seem to be able to use CuPy without issues

Since the headers and includes from the CTK typically are installed to %CONDA_PREFIX%\Library, wonder if we should update this to point to that location

-set "CUDA_PATH=%CONDA_PREFIX%"
+set "CUDA_PATH=%CONDA_PREFIX%\Library"

Though looking at this logic in CuPy, am not sure if we should point to %CONDA_PREFIX%\Library\bin instead

Thoughts?

jakirkham commented 10 months ago

It's worth noting there is also some discussion about updating or dropping the activation script ( https://github.com/conda-forge/cupy-feedstock/issues/206 ), which might also affect how this is handled

leofang commented 10 months ago

Let us move the discussion to #206, I think it's the same issue.

leofang commented 10 months ago

See https://github.com/conda-forge/cupy-feedstock/issues/206#issuecomment-1819832486.

jakirkham commented 10 months ago

Ok I read that as Linux whereas the issue here is Windows

The targets point specifically doesn't apply to Windows

On Windows, we have a more similar CTK structure between CUDA 11 / 12

leofang commented 10 months ago

Ok I read that as Linux whereas the issue here is Windows

The targets point specifically doesn't apply to Windows

On Windows, we have a more similar CTK structure between CUDA 11 / 12

To CuPy the same applies to Linux as well. All headers and shared libraries can be found in the targets directory, enough to ensure a fully functional CuPy runtime.

jakirkham commented 10 months ago

Ok let's close then