search

conda-forge / cupy-feedstock

A conda-smithy repository for cupy.
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

Retry using VS2019 #250

Closed h-vetinari closed 8 months ago

h-vetinari commented 8 months ago

Almost a year ago, 15ab48209a3d3714e30858524c00f3c4395ab271 went back to VS2017 due to some apparent issues at the time. It would be good to remove https://github.com/conda-forge/cupy-feedstock/blob/95b2a2daefc4272c3d29a5898bcf11bfe64cd3af/recipe/conda_build_config.yaml#L1-L4

and just use the conda-forge default compilers, as cupy is among the last feedstocks in conda-forge to still use VS2017.

This is hopefully easier now with the intervening work to update CUDA versions (and drop <11.2)? 🤞

h-vetinari commented 8 months ago

Thanks for the quick response!

leofang commented 8 months ago

Thanks @h-vetinari for reminder, this was on my backburner. I still don't know how/when the bug that forced us to stay on vs2017 was fixed, but it seems working out just fine!