search

conda-forge / cupy-feedstock

A conda-smithy repository for cupy.
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

Marking old CuPy 13 packages (with activation scripts) broken #255

Open jakirkham opened 8 months ago

jakirkham commented 8 months ago

After discussion in issue ( https://github.com/conda-forge/cupy-feedstock/issues/206 ), we decided recently to drop the activation scripts from CuPy packages ( https://github.com/conda-forge/cupy-feedstock/pull/252 ). This happened in CuPy 13 packages, but only started with build/number: 3. As this is a breaking change and it happened in a later build/number, some CuPy 13 packages have activation scripts and others do not. To make the user experience more consistent, it would be preferable for CuPy 13 packages that had activation scripts to be marked broken. This way the breaking change of removing activation scripts aligns to installing CuPy 13 (a major version that can contain other breaking change)

Note: This is a follow up to comment ( https://github.com/conda-forge/cupy-feedstock/issues/206#issuecomment-1927749544 ) and offline discussion with @leofang and @mtjrider where we thought this would be a reasonable change

jakirkham commented 8 months ago

If this is reasonable, the next steps would be:

leofang commented 6 months ago

@mtjrider is this something you can help with?

mtjrider commented 6 months ago

Yup. It's in my backlog for today.

I'll comment again later today.

mtjrider commented 6 months ago

Yup. It's in my backlog for today.

I'll comment again later today.

Checking in. I'm wrapping up a few other actions today and can get this knocked out in the afternoon.

jakirkham commented 5 months ago

@mtjrider did you put something together? Do you need a review?