search

conda-forge / cupy-feedstock

A conda-smithy repository for cupy.
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

Enable cuDNN in all builds #266

Closed conda-forge-admin closed 5 months ago

conda-forge-admin commented 5 months ago

Fixes #224

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 5 months ago

@conda-forge-admin , please re-render

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

jakirkham commented 5 months ago

@leofang can you please review?

leofang commented 5 months ago

LGTM modulo some questions:

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 5 months ago
  • Can we fix the linter error?

Done. Wrote it on my phone. So no idea how it handles EOF editing

  • Are there use cases? Note that CuPy plans to deprecate/remove cuDNN support (Support cuDNN 9.0 cupy/cupy#8215 (comment)), and so no plan to move to cuDNN 9.0+. We might end up removing the 8.x support at some point.

We already have it elsewhere. So this just handled it uniformly across architectures

That's ok. Whenever upstream drops it or it becomes unwieldy, we can too

jakirkham commented 5 months ago

One of the builds had a network issue. Will restart once the rest finish (otherwise Azure restarts all builds instead of just failing ones)

github-actions[bot] commented 5 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!