Closed seberg closed 1 month ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin , please re-render
@conda-forge-admin , please re-render
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Disabled more tests so that we can get the artifacts built for local testing
Also more details on using the artifacts from CI in issue: https://github.com/conda-forge/conda-forge.github.io/issues/1424
Now that there are CuPy 13.2.0 packages with NumPy 2.0 support ( https://github.com/conda-forge/cupy-feedstock/pull/275 ), is this still needed? Or can we close this out?
@conda-forge-admin , please re-render
Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.
@jakirkham I'll create a new PR today to test for the upcoming 13.x release. We can probably close this one (maybe I'll update it, too). I am not sure that it is too relevant for anyone (from the RAPIDS side, I think testing with 13.x is more interesting currently, the promotion changes seem too subtle to create serious problems/test failures).
EDIT: Ah, I see you already started working on switching to 13.x.dev, thanks!
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml
) and found it was in an excellent condition.
@jakirkham I'll create a new PR today to test for the upcoming 13.x release
Ha! Was just about to ask for your help checking that we have the right things in here. Since you are already looking 😉
Should add it would be good to share these artifacts with folks working on CuPy + SciPy compatibility. They ran into a few issues as well and could benefit from fresh binaries with the patches already applied for testing (and seeing if anything else still remains)
Here are a couple issues that I came across recently:
Though you likely know better than me on how best to coordinate with them 🙂
Also we may want to restart whenever PR ( https://github.com/cupy/cupy/pull/8439 ) lands (and anything else I've forgotten about). Can just close and reopen the PR
Thanks, looks like this should work. Hopefully, that the last CuPy PR will auto-merge, without that cuml/cudf/cucim sanity testing might not make much sense.
Will adapt my cudf hack once that is done and share it over at SciPy (also I suspect that I can use cph extract
or maybe even file://
without extracting, so will try that):
Close/reopen to retrigger with the random seed fix (will take a while for new artifacts to be available).
Weird Windows isn't building. Am seeing errors like this on CI:
Exception: Your CUDA environment is invalid. Please check above error log.
It can't find DLPack, which is odd as the git submodule is cloned earlier
dlpack : No
-> Include files not found: ['cupy/_dlpack/dlpack.h']
-> Check your CFLAGS environment variable.
Edit: Looks like upstream issue ( https://github.com/cupy/cupy/issues/7989 )
Close re-open once more, so we have newer CuPy 13.3.0 pre-release build available for testing (I'll probably run at least one sanity check with these, e.g. with cuml).
Hmmm, using this (after installing cudatoolkit-dev
), the cuml test suite is looking pretty good, but I do see these failures (all in doctests):
OK those failures must be related to https://github.com/cupy/cupy/pull/8483 which changes the output stream of random.choice
and that is used when making classification problems (also make_blobs
).
I don't think this is worrying, CuPy team has to know if they mind modifying the stream like this (even if it is a huge improvement). For cuML, it seems fine to adjust/skip the tests as necessary.
@conda-forge-admin , please re-render
Yeah, not sure, but it seemed to me that cudatoolkit-dev
is what made it work in the end... (I guess just checking whether it includes vector_types.h
might make sense.)
So cudatoolkit-dev
is a thin wrapper around the CUDA Toolkit runfile installer. That will install the full CTK onto the system in /usr/local/cuda
One could get an equivalent result with Conda packages by running conda install cuda=<x.y>
, which also installs the full CTK (except for the driver)
While both of these will technically work, we don't want users to need to resort to this. After all we have the full CTK in conda packages. So just adding the right ones as dependencies to cupy
should resolve the issue
As to vector_types.h
, looked inside cuda-cudart-dev_linux-64
(as one example) and they do appear to be there
However CuPy doesn't know how to look inside the targets
structure at runtime (Leo recently added logic for this at build time). So think we need a patch similar to this one made for wheels also for conda packages: https://github.com/cupy/cupy/pull/8489
Upstream v13
now includes these fixes that we need:
So switched back to building with upstream's v13
Going to start fresh a CI build for the latest v13
branch
@conda-forge-admin , please restart CI
@conda-forge-admin , please restart CI
Looks like that is working! 🥳
Will retest with the latest changes to make sure that is still the case
@conda-forge-admin , please restart CI
Closing this, now that gh-282 is merged. If we need 14.0 pre-releases again, probably best to start fresh I think.
Thanks a lot for all the work, @seberg @jakirkham!
This (tries to) build artifacts based on Evgeni's PR to CuPy which should have most fixes needed to run with NumPy 2 and thus allow testing downstream projects with NumPy 2 if they also need CuPy.
This includes most/all necessary Python fixes as well as fixes to make promotion align with NumPy (NEP 50).
See also:
(Note that I'll presumably will churn CI a bit before this actually works...)