search

conda-forge / cupy-feedstock

A conda-smithy repository for cupy.
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

Pulling 7.1.0 #31

Closed jakirkham closed 4 years ago

jakirkham commented 4 years ago

It appears there was a pretty serious bug in CuPy 7.1.0. ( https://github.com/cupy/cupy/issues/2971 ) Would like to pull the packages from conda-forge so that others don't run into this issue. Thoughts?

leofang commented 4 years ago

https://github.com/cupy/cupy/issues/2971#issuecomment-575402543

leofang commented 4 years ago

Please feel free to delete the published packages if you want. Either way, I would add a patch in the recipe to fix it.

jakirkham commented 4 years ago

We don’t normally delete packages, but we do move them to the broken label if there are issues. It’s still possible for people to opt to install the package that way.

Adding a patch and rebuilding is a quite common solution. This would be a good solution if it seems agreeable.

leofang commented 4 years ago

Let me try putting together a patch PR.

jakirkham commented 4 years ago

Sounds good. Thanks Leo! 😄

leofang commented 4 years ago

but we do move them to the broken label if there are issues.

@jakirkham How do we maintainers do this?

jakirkham commented 4 years ago

Unfortunately there is not a way currently. It's definitely a request we have with Anaconda.

jakirkham commented 4 years ago

Though I should say that the usual approach (currently) is maintainers ask @conda-forge/core to assist with moving the packages to broken.

jakirkham commented 4 years ago

FWIW I've gone ahead and marked 7.1.0 packages from yesterday as broken. After all we have included the patch in the new builds and they already can be downloaded. Please let me know if I missed any or got any incorrectly. 🙂

leofang commented 4 years ago

Thanks for doing this, John! I think you tagged it right.