Closed regro-cf-autotick-bot closed 4 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Let me work on this later.
@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.
@conda-forge/cupy For CuPy core devs: The PyPI source only contains cythonized cpp
files and no pyx
files? Was that done on purpose or just an oversight? It seems we can't switch to PyPI release and close #34...? 😞
Ah, I guess setuptools is OK with the cpp sources. The real issue is that in the PyPI release the CUB sources are not included (likely because in the build script CUB_PATH
was not set), see here: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=121103&view=logs&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=6d4b912b-175d-51da-0fd9-4d30fe1eb4e7&l=1827
I can confirm that both cupy/cuda/cub.cpp
and cupy/cuda/cupy_cub.cu
are absent.
We are not seeing that in the GitHub tarball though, right?
No, otherwise the build would fail. This is ready to go I think. We’ll revisit the PyPI issue when CUB is bundled in CuPy.
Yep that makes sense. Just wanted to make sure I wasn’t missing anything 🙂
Thanks for working on this @leofang! 😀
It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:
license_file
is packagedNote that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/14379, please use this URL for debugging