Re-enable CUB support - Githubissues

conda-forge / cupy-feedstock

A conda-smithy repository for cupy.

BSD 3-Clause "New" or "Revised" License

5 stars 23 forks source link

Re-enable CUB support #40

Closed jakirkham closed 4 years ago

jakirkham commented 4 years ago

Applies the patch from PR ( https://github.com/cupy/cupy/pull/3152 ) to 7.2.0 builds to fix the CUB issue and re-enable CUB support.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 4 years ago

@conda-forge-admin, please re-render.

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like I wasn't able to push to the re-enable_cub branch of jakirkham-feedstocks/cupy-feedstock. Did you check the "Allow edits from maintainers" box?

jakirkham commented 4 years ago

WDYT @leofang? 🙂

jakirkham commented 4 years ago

Oops 😳 Should be fixed now. Thanks 😀

Do you know what this CI job is doing? Just trying to understand what it is doing if it is not testing CUB. 🙂

leofang commented 4 years ago

That was meant to test the CUB module (with the env var CUB_DISABLED=0) when the source tree is bundled, but so far it's not, so other than setting CUB_DISABLED it is the same as other CIs.

AFAIK the bundling work is blocked by this PR: https://github.com/chainer/chainer-test/pull/564 If you happen to know Ubuntu well you should help them out! 🙂

jakirkham commented 4 years ago

Ah ok. Thanks for the context.

I'll admit I would like to see your PR ( https://github.com/cupy/cupy/pull/2584 ) merged so that we have CUB by default with testing.

That said, all of the failures with CUB seem to have come from mainly one PR. I'm hopeful that we have fixed them all, but I could be wrong.

jakirkham commented 4 years ago

Talked with @JohnZed offline and he thinks we should hold off until PR ( https://github.com/cupy/cupy/pull/2584 ) lands as well. Closing this out. We can revisit CUB after that lands.

leofang commented 4 years ago

Oh oh, OK. Sorry for your time, John 😅

jakirkham commented 4 years ago

No worries 😄 My bad. Thought that CI job meant it was tested initially.