conda-forge / cupy-feedstock

A conda-smithy repository for cupy.
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

Tidy selectors #50

Closed jakirkham closed 4 years ago

jakirkham commented 4 years ago

Cleans up the selectors a bit to delineate the cases that we skip a bit more. Namely Python 2.7 is dropped in CuPy 7. PyPy has some issues (hopefully all now fixed upstream 🍀). Finally CUDA support is required to build.

As a last tweak, we now skip builds only when cuda_compiler_version is undefined or None (as opposed to skipping on linux64 builds). This should make it trivial to add new architectures as CUDA builds become available for them without requiring changes here (outside of a re-render).

Checklist

Edit: Ignoring build number as this doesn't change how the packages are built.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 4 years ago

@conda-forge-admin, please re-render.

(should be a no-op)

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

jakirkham commented 4 years ago

@conda-forge-admin, please re-render.

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

leofang commented 4 years ago

Hi @jakirkham, sorry for my slowness. I have a few questions:

jakirkham commented 4 years ago

No worries. Sorry had figured this was probably not too interesting to others.

Jinja defines undefined to make it easier to check if a variable is not defined.

This still depends on Anaconda to publish cudatoolkit packages for other architectures. That said, it seems like a good idea to adopt this practice early so we are ready once that happens. Plus it can be included in docs for others to use 😉

leofang commented 4 years ago

Got it, thanks John!

leofang commented 4 years ago

Not sure what happened, but this PR didn't upload while #51 did...

jakirkham commented 4 years ago

Hmm...probably the package hash changed for some reason. It's probably harmless, but would be ok pulling the package if you prefer. WDYT?

leofang commented 4 years ago

Yeah it's ok to leave them. It's harmless indeed. Just wondered why. 🙂