Release 9.0.0b1 - Githubissues

conda-forge / cupy-feedstock

A conda-smithy repository for cupy.

BSD 3-Clause "New" or "Revised" License

5 stars 23 forks source link

Release 9.0.0b1 #91

Closed jakirkham closed 3 years ago

jakirkham commented 3 years ago

This sets up a release of 9.0.0b1 under an RC label following the procedure for RCs in CFEP-05.

cc @quasiben @grlee77

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 3 years ago

Looks like there are Cython compilation errors coming up on CI. Do these look familiar to anyone? Any chance we are missing an upstream change that we need?

leofang commented 3 years ago

@jakirkham This is a known sdist issue being discussed in cupy/cupy#4494. For the time being, can we build from source (git branch)?

grlee77 commented 3 years ago

Thanks, @leofang.

Also, remember to run git submodule update --init after checking out the repo since CUB and Jitify both are submodules now.

jakirkham commented 3 years ago

This is a known sdist issue being discussed in cupy/cupy#4494. For the time being, can we build from source (git branch)?

Ok thanks Leo! 😄 So should we be using that PR or is the tag fine?

Edit: Trying with the tag to start.

Edit 2: This seems to be working 🍀 😁

jakirkham commented 3 years ago

Also, remember to run git submodule update --init after checking out the repo since CUB and Jitify both are submodules now.

I believe conda-build does that for us, but if it doesn't will add that manually.

leofang commented 3 years ago

Let's try tag for now. That branch is yet to be discussed.

jakirkham commented 3 years ago

Sounds good. Trying that in the latest changes. So far CI is past the Cython step and on to the C/C++ compilation step. Hoping that means we are good 🍀 😁

leofang commented 3 years ago

Question: in the long run, perhaps we'd like to maintain two branches per feedstock, one for rc and the other for stable releases?

jakirkham commented 3 years ago

We certainly can. RAPIDS had a need for this release hence why we picked this up now, but we could routinize this process if theres's interest. It's not too difficult 🙂

jakirkham commented 3 years ago

Thanks all! 😄