Enable unicode on windows

conda-forge / curl-feedstock

A conda-smithy repository for curl.

BSD 3-Clause "New" or "Revised" License

3 stars 42 forks source link

Enable unicode on windows #100

Closed jaimergp closed 2 years ago

jaimergp commented 2 years ago

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jaimergp commented 2 years ago

@conda-forge-admin, please rerender

jaimergp commented 2 years ago

Current release doesn't mention Unicode in its features:

curl -V
curl 7.80.0 (x86_64-pc-win32) libcurl/7.80.0 Schannel zlib/1.2.11 libssh2/1.10.0
Release-Date: 2021-11-10
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: AsynchDNS HSTS IPv6 Kerberos Largefile NTLM SPNEGO SSL SSPI UnixSockets alt-svc libz

... but it does work:

wolfv commented 2 years ago

Yeah, this is the code path we need to take inside curl: https://github.com/curl/curl/blob/b31d9ccfc2da288900e6857ad8d048c612328cac/lib/curl_multibyte.c#L117-L133

To use the wfopen functions and encode the string into wide chars (UTF-16).

wolfv commented 2 years ago

I think ENABLE_UNICODE should've worked! Thanks @jaimergp !

jaimergp commented 2 years ago

Confirmed: it solved our issues! If anybody else is experiencing unicode problems on Windows, make sure to have curl 0.18 *_1 or greater