curl v7.84.0 - Githubissues

regro-cf-autotick-bot commented 2 years ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

[ ] Dependencies have been updated if changed: see upstream
[ ] Tests have passed
[ ] Updated license if changed and license_file is packaged

Information about this PR:

Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.
The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name	Upstream Version	Current Version
curl	7.84.0

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2568010325, please use this URL for debugging.}

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

FaustinCarter commented 1 year ago

@jakirkham @msarahan @ocefpaf @xylar Can one of you check this out? The last two releases of libcurl haven't made it through CI so conda-forge is running pretty behind.

FaustinCarter commented 1 year ago

I dug through the 7.85 failure logs (since the 7.84 ones are so old they got deleted) and it is dying during the test phase for the curl output package. The relevent lines of the log file are:

2022-08-31T13:38:08.8164755Z (%PREFIX%) %SRC_DIR%>curl --help 
2022-08-31T13:38:08.8345284Z 
2022-08-31T13:38:08.8346912Z (%PREFIX%) %SRC_DIR%>IF -1073741515 NEQ 0 exit /B 1

It looks to me, like the test is trying to run curl.exe, but is failing with a File System Error (exit code -1073741515). Some cursory Googling suggests the most likely culprit is a missing dll somewhere.

ocefpaf commented 1 year ago

I'm not sure. Let's try to restart things and investigate.

@conda-forge-admin, please rerender

FaustinCarter commented 1 year ago

@ocefpaf Here's the conda-build test output for the failing job. Any thoughts on why calling curl --help would be throwing a File System Error (exit code -1073741515)? Is there a missing DLL that windows needs that isn't getting bundled?

The following NEW packages will be INSTALLED:

    ca-certificates: 2022.9.24-h5b45459_0    conda-forge
    curl:            7.84.0-heaf79c2_0       local      
    krb5:            1.19.3-hc8ab02b_0       conda-forge
    libcurl:         7.84.0-heaf79c2_0       local      
    libssh2:         1.10.0-h9a1e1f7_3       conda-forge
    libzlib:         1.2.12-hcfcfb64_3       conda-forge
    openssl:         3.0.5-hcfcfb64_2        conda-forge
    ucrt:            10.0.20348.0-h57928b3_0 conda-forge
    vc:              14.2-hb210afc_7         conda-forge
    vs2015_runtime:  14.29.30139-h890b9b1_7  conda-forge

Preparing transaction: ...working... done
Verifying transaction: ...working... done
Executing transaction: ...working... done
set PREFIX=D:\bld\curl_split_recipe_1664198299095\_test_env
set SRC_DIR=D:\bld\curl_split_recipe_1664198299095\test_tmp

(base) %SRC_DIR%>call "%SRC_DIR%\conda_test_env_vars.bat" 

(base) %SRC_DIR%>set "CONDA_SHLVL="   && 

(base) %SRC_DIR%>conda activate "%PREFIX%" 

(%PREFIX%) %SRC_DIR%>IF 0 NEQ 0 exit /B 1 

(%PREFIX%) %SRC_DIR%>call "%SRC_DIR%\run_test.bat" 

(%PREFIX%) %SRC_DIR%>curl --help 

(%PREFIX%) %SRC_DIR%>IF -1073741515 NEQ 0 exit /B 1 

(%PREFIX%) %SRC_DIR%>IF 1 NEQ 0 exit /B 1 
Tests failed for curl-7.84.0-heaf79c2_0.tar.bz2 - moving package to D:\bld\broken
WARNING:conda_build.build:Tests failed for curl-7.84.0-heaf79c2_0.tar.bz2 - moving package to D:\bld\broken
TESTS FAILED: curl-7.84.0-heaf79c2_0.tar.bz2

ocefpaf commented 1 year ago

File System Error (exit code -1073741515)? Is there a missing DLL that windows needs that isn't getting bundled?

No idea. I don't have a working Windows machine with me to test it out. I'll try to fix my Windows partition on my laptop to check this problem.

jakirkham commented 1 year ago

@isuruf, do we have a Windows machine in the cloud that we could use for testing here? No worries if not. Just know it can be a bit of work to dust off a mostly unused OS partition and wondering if we might have an easier path for testing here 🙂

isuruf commented 1 year ago

You don't need a windows machine to see the issue. (We do have one. Ask Sylvain if you need access) You can see the issue in CI

WARNING (libcurl,Library/bin/libcurl.dll): $RPATH/zlibwapi.dll not found in packages, sysroot(s) nor the missing_dso_whitelist. 2022-09-26T13:26:44.1346842Z .. is this binary repackaging?

Should be fixed by https://github.com/conda-forge/zlib-feedstock/pull/67

jakirkham commented 1 year ago

Thanks Isuru! 🙏