Enable Zstd support for Linux/MacOS

conda-forge / curl-feedstock

A conda-smithy repository for curl.

BSD 3-Clause "New" or "Revised" License

3 stars 42 forks source link

Enable Zstd support for Linux/MacOS #108

Closed Shelnutt2 closed 1 year ago

Shelnutt2 commented 1 year ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

This enables Zstd support for http compressor in curl. Zstd is added as a dependency for unix. The windows Makefile.vc does not currently support Zstd, so windows is left untouched.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Shelnutt2 commented 1 year ago

Please note that the windows build is failing. It appears on master currently this is failing. While master has passed back in May if the build is rerun locally or in Azure it currently is failing. This is unrelated to my changes in this PR.

ocefpaf commented 1 year ago

@Shelnutt2 sorry for waiting so long on this. Do you mind if we wait for a new curl release to add this change? It would make our migration easier.

Shelnutt2 commented 1 year ago

@Shelnutt2 sorry for waiting so long on this. Do you mind if we wait for a new curl release to add this change? It would make our migration easier.

@ocefpaf no problem to wait for next release, thanks for considering this!

Shelnutt2 commented 1 year ago

Hello @ocefpaf I wanted to check in and see if now that 7.88.1 was shipped if this change could be reconsider? Thanks in advance!

ocefpaf commented 1 year ago

Probably not. We lost track of this. Do you mind refreshing this PR so we can merge it?

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Shelnutt2 commented 1 year ago

Probably not. We lost track of this. Do you mind refreshing this PR so we can merge it?

I've pushed a rebase. Thanks again for considering this!