conda-forge / curl-feedstock

A conda-smithy repository for curl.
BSD 3-Clause "New" or "Revised" License
3 stars 44 forks source link

Add a macos static build that (re-)enables securetransport #111

Closed wolfv closed 2 years ago

wolfv commented 2 years ago

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

wolfv commented 2 years ago

@isuruf would you be willing to merge this PR? It would be quite nice to release micromamba 1.0 with updated curl (& libarchive) :)

wolfv commented 2 years ago

I think that didn't work in the past:

isuruf commented 2 years ago

How about the default being ---with-openssl --with-secure-transport -with-default-ssl-backend=openssl and then micromamba can use secure-transport by default?

wolfv commented 2 years ago

Happy to try that.

isuruf commented 2 years ago

curl_global_sslset is the function to do that.

wolfv commented 2 years ago

yeah, we're using that function already https://github.com/mamba-org/mamba/blob/c5d73a204b19311114885f3081b86e7d881e151e/libmamba/src/core/fetch.cpp#L45-L49

wolfv commented 2 years ago

Closing in favor of #112