Add secure-transport on macOS

conda-forge / curl-feedstock

A conda-smithy repository for curl.

BSD 3-Clause "New" or "Revised" License

3 stars 44 forks source link

Closed wolfv closed 2 years ago

wolfv commented 2 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

wolfv commented 2 years ago

cc @isuruf I think this works. Needs a bit of a change in micromamba, but I can easily patch that!

isuruf commented 2 years ago

Looks good. Can you check that curl-config --ssl-backends have both backends in macos?

wolfv commented 2 years ago

I just added a test to check that.

isuruf commented 2 years ago

Looks good to me. I'm not a maintainer of this feedstock. @conda-forge/curl, thoughts?

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing, but could not be merged (error=API error in POST to merge).

jakirkham commented 2 years ago

This is a nice improvement. Thank you both! 🙏