Closed schribl closed 8 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
@msarahan @jakirkham @ocefpaf @xylar Gentle ping, is this change okay or are additional steps needed if a new dependency is added to a recipe?
Thanks @schribl. This looks good to me. @ocefpaf or @jakirkham, do you have time to take a quick look and merge if you're happy? curl
is one where I've been hesitant to merge myself because I have very little relevant expertise and it affects a lot of folks.
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
This has been deprecated in favor of the top-level `test` field.
It is now mapped to `test: native_and_emulated`.
Failed validating 'deprecated' in schema['properties']['test_on_native_only']:
{'anyOf': [{'type': 'boolean'}, {'type': 'null'}],
'default': False,
'deprecated': True,
'description': 'This was used for disabling testing for '
'cross-compiling.\n'
'\n'
'```warning\n'
'This has been deprecated in favor of the top-level '
'`test` field.\n'
'It is now mapped to `test: native_and_emulated`.\n'
'```',
'title': 'Test On Native Only'}
On instance['test_on_native_only']:
True
These latest changes look good to me. @ocefpaf, if you're happy, please merge.
133 Does not work as according to this information PSL either need to be present of explicitly disabled:
https://curl.se/changes.html
This also mitigates this CVE: https://curl.se/docs/CVE-2024-0853.html
According to the discussion, this PR updates & explicitly disables the PSL feature.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)closes #133