conda-forge / curl-feedstock

A conda-smithy repository for curl.
BSD 3-Clause "New" or "Revised" License
3 stars 42 forks source link

8.6.0 #134

Closed schribl closed 3 months ago

schribl commented 3 months ago

133 Does not work as according to this information PSL either need to be present of explicitly disabled:

https://curl.se/changes.html

This also mitigates this CVE: https://curl.se/docs/CVE-2024-0853.html

According to the discussion, this PR updates & explicitly disables the PSL feature.

Checklist

closes #133

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

schribl commented 3 months ago

@conda-forge-admin, please rerender

schribl commented 3 months ago

@msarahan @jakirkham @ocefpaf @xylar Gentle ping, is this change okay or are additional steps needed if a new dependency is added to a recipe?

xylar commented 3 months ago

Thanks @schribl. This looks good to me. @ocefpaf or @jakirkham, do you have time to take a quick look and merge if you're happy? curl is one where I've been hesitant to merge myself because I have very little relevant expertise and it affects a lot of folks.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

This has been deprecated in favor of the top-level `test` field.
It is now mapped to `test: native_and_emulated`.
        Failed validating 'deprecated' in schema['properties']['test_on_native_only']:
            {'anyOf': [{'type': 'boolean'}, {'type': 'null'}],
             'default': False,
             'deprecated': True,
             'description': 'This was used for disabling testing for '
                            'cross-compiling.\n'
                            '\n'
                            '```warning\n'
                            'This has been deprecated in favor of the top-level '
                            '`test` field.\n'
                            'It is now mapped to `test: native_and_emulated`.\n'
                            '```',
             'title': 'Test On Native Only'}

        On instance['test_on_native_only']:
            True
xylar commented 3 months ago

These latest changes look good to me. @ocefpaf, if you're happy, please merge.