Enable websockets in build

conda-forge / curl-feedstock

A conda-smithy repository for curl.

BSD 3-Clause "New" or "Revised" License

3 stars 42 forks source link

Enable websockets in build #139

Closed jamespinkerton closed 5 days ago

jamespinkerton commented 1 week ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 week ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see https://github.com/conda-forge/conda-forge.github.io/issues/2102.

ocefpaf commented 1 week ago

I'm usually afraid of adding more options to such wide used libraries that tons of other packages link to. With that said:

Can you explain why you need this and why we should consider merging?
@isuruf, as usually sorry for the ping, but do you foresee any problems or is this one safe to merge?

jamespinkerton commented 1 week ago

I get that it’s a valid concern. This flag is needed to use libcurl to interact with ws:// and wss:// connections, which I would like to do. My entire environment uses conda-forge and I can’t easily use libcurl without getting it through conda.

ocefpaf commented 1 week ago

I get that it’s a valid concern. This flag is needed to use libcurl to interact with ws:// and wss:// connections, which I would like to do. My entire environment uses conda-forge and I can’t easily use libcurl without getting it through conda.

If I don't get a comment from an expert in 1-2 days I'll merge this one.

jamespinkerton commented 5 days ago

Quick question (I'm sure this is a dumb question). How do we upload this change as a new version in the conda forge channels?

ocefpaf commented 4 days ago

Quick question (I'm sure this is a dumb question). How do we upload this change as a new version in the conda forge channels?

Build number 1 should be in the channel already.

jamespinkerton commented 4 days ago

My apologies but I don't see it in the channel?

jakirkham commented 4 days ago

The build did not start on Azure. Have manually started it