search

conda-forge / curl-feedstock

A conda-smithy repository for curl.
BSD 3-Clause "New" or "Revised" License
3 stars 44 forks source link

make curl thread-safe #18

Closed kuepe-sl closed 6 years ago

kuepe-sl commented 7 years ago

Solves #19 make thread-safe by compiling with --enable-threaded-resolver This option is used by current Debian distributions as well.

Without this option (or c-ares support), libcurl can crash when not called from the main-thread.
see https://stackoverflow.com/a/22957000 and https://www.redhat.com/archives/libvir-list/2012-September/msg01960.html

EDIT: The Travis CI build failed, but I don't think that's caused by the new configuration parameter. If someone could clear that up, that would be nice.

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 7 years ago

Toggling as some new curl dependencies have been added and the version bumped. It would be nice to see if this now works.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

jakirkham commented 6 years ago

Oops, sorry. Thought I had reopened this before. Will work on getting this refreshed.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 6 years ago

So I've checked Homebrew and MacPorts. Neither of them are setting this currently. That said, I'm not seeing any explanation for why nor any indication that it would cause problems. Appears Arch Linux and Fedora also uses this.

kuepe-sl commented 6 years ago

Sorry for the lack of response.

I added a workaround (setting CURLOPT_NOSIGNAL to 1) for the issue to my programs shortly after opening the pull request. Thus I didn't get any further crashes regardless of the library being fixed or not.

ocefpaf commented 6 years ago

Closing and re-opening to restart the CIs.

ocefpaf commented 6 years ago

@kuepe-sl closing this as stale then. If you ever need to implement this again please open a new PR. Thanks!