conda-forge / curl-feedstock

A conda-smithy repository for curl.
BSD 3-Clause "New" or "Revised" License
3 stars 42 forks source link

Update curl #21

Closed ocefpaf closed 6 years ago

ocefpaf commented 6 years ago

I also added the vcs here.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 6 years ago

AppVeyor shows an error that we are missing:

libssh2.lib(crypt.c.obj) : error LNK2019: unresolved external symbol _EVP_CIPHER_CTX_cleanup referenced in function _crypt_dtor
..\builds\libcurl-vc9-x86-release-dll-zlib-dll-ssh2-dll-ipv6-sspi-winssl-obj-lib\libcurl.dll : fatal error LNK1120: 68 unresolved externals
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\link.exe"' : return code '0x460'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\nmake.exe"' : return code '0x2'
Stop.
(C:\bld\curl_1500654882454\_b_env) C:\bld\curl_1500654882454\work\curl-7.54.1\winbuild>if 2 EQU 1 exit 1 

and the curl call at test time is from AppVeyor's built-in curl:

(C:\bld\curl_1500661388395\_t_env) (root) C:\bld\curl_1500661388395\test_tmp>curl --version 
curl 7.54.0
(C:\bld\curl_1500661388395\_t_env) (root) C:\bld\curl_1500661388395\test_tmp>where curl 
C:\Tools\curl\bin\curl.exe
nehaljwani commented 6 years ago

This is probably failing because the libssh2 package on the channel is a static lib and not a shared lib. We probably need to fix https://github.com/conda-forge/libssh2-feedstock/pull/9 and then build that package, and then trigger this one.

ocefpaf commented 6 years ago

This is probably failing because the libssh2 package on the channel is a static lib and not a shared lib. We probably need to fix https://github.com/conda-forge/libssh2-feedstock/pull/9 and then build that package, and then trigger this one.

Now https://github.com/conda-forge/libssh2-feedstock/pull/11

ocefpaf commented 6 years ago

Thanks @nehaljwani for starting this. It seems that curl is finally back on track!