search

conda-forge / curl-feedstock

A conda-smithy repository for curl.
BSD 3-Clause "New" or "Revised" License
3 stars 42 forks source link

Fix hardcoded cert path in `curl` libs #3

Closed jakirkham closed 8 years ago

jakirkham commented 8 years ago

Appears the curl libraries are hard-coding the path to the certs in their libraries. This is pretty bad. I'm not sure if this will be ok for us to fix, but we need to do it somehow as it is confusing git (though I think we have found a way around that) and causing curl problems downloading with HTTPS. This is an attempt to fix curl so that it uses the certs correctly. Feedback welcome.

cc @msarahan @pelson

conda-forge-linter commented 8 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 8 years ago

Looks like this might not be necessary after all, but maybe we should keep it just in case.

jakirkham commented 8 years ago

After looking more closely, I'm thinking this is still necessary, but am trying to come with a good test to demonstrate the problem.

jakirkham commented 8 years ago

Alright, I have added a test up here that seems to demonstrate the failure I am seeing on *NIXes. Windows seems to be unaffected (probably using some sort of native SSL). Will push the fix after the CIs complete.

jakirkham commented 8 years ago

Fix has been pushed now so that we can see that it works.

msarahan commented 8 years ago

Thanks for tracking this down

jakirkham commented 8 years ago

Of course. Were you running into this too?

msarahan commented 8 years ago

No, sadly I've been buried with conda build 1.20.3 and customer stuff. Have not played with this lately. Still, I see where this might go wrong and appreciate your fix.

On Thu, May 19, 2016, 18:49 jakirkham notifications@github.com wrote:

Of course. Were you running into this too?

— You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub https://github.com/conda-forge/curl-feedstock/pull/3#issuecomment-220480683

jakirkham commented 8 years ago

No, sadly I've been buried with conda build 1.20.3 and customer stuff.

Sorry to hear that.

Have not played with this lately.

Well, hopefully, it will work when you do. 😄

Still, I see where this might go wrong and appreciate your fix.

Of course.

Speaking of fixes. I think I have figured out why the Windows builds of git were broken. Here's a PR ( https://github.com/conda-forge/git-feedstock/pull/11 ) to fix them. Please take a look when you have a chance.