search

conda-forge / curl-feedstock

A conda-smithy repository for curl.
BSD 3-Clause "New" or "Revised" License
3 stars 42 forks source link

Gcc7 #38

Closed ocefpaf closed 5 years ago

ocefpaf commented 5 years ago

Same as #35 but without defaults so we can assess what is missing.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 5 years ago

@CJ-Wright and @mariusvniekerk this fails, as expected, with the new compilers due to missing packages. I wonder if we should make the default behavior to remove defaults during the compiler migration (pun intended :smile:).

CJ-Wright commented 5 years ago

Zlib is in a cycle, so I don't know if this will help. Having defaults in to help us bootstrap would be nice since we can then do another round of builds once the cycle is done and remove defaults, allowing us to do a proper self consistent bootstrap.

ocefpaf commented 5 years ago

Having defaults in to help us bootstrap would be nice since we can then do another round of builds once the cycle is done and remove defaults, allowing us to do a proper self consistent bootstrap.

Sounds good. Even though I would like to try that in the first cycle it is probably faster to cycle twice rather than fixing point issues here and there.

CJ-Wright commented 5 years ago

Do we need to update this from anaconda recipes?

ocefpaf commented 5 years ago

Do we need to update this from anaconda recipes?

Probably. There is also the curl/libcurl naming issue we must decide.

CJ-Wright commented 5 years ago

Ah yes