Closed jakirkham closed 8 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
This is clearly working and needed for a clean build. Going to go ahead and merge. If we want to have discussion about other ways to have a clean build that is totally fine, but can be discussed after getting it fixed.
Turns out
curl
requiresperl
to run the tests on UNIX. This can be demonstrated by this CircleCI build. As the copy ofperl
on the docker image gave us a false sense of havingperl
, we must now address this properly and makeperl
a build dependency.Didn't bump the build number as this only affects the tests. It doesn't affect the binaries we provide.