add static build for windows

conda-forge / curl-feedstock

A conda-smithy repository for curl.

BSD 3-Clause "New" or "Revised" License

3 stars 43 forks source link

Closed wolfv closed 4 years ago

wolfv commented 4 years ago

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

wolfv commented 4 years ago

we should probably also split the static library for UNIX in the spirit of CFEP 18. I can do this in this PR or in another, as you wish.

Just FYI this is to enable a statically linked micromamba on Windows.

mariusvniekerk commented 4 years ago

Doing the split in this PR seems correct

wolfv commented 4 years ago

since the static lib has now been removed, I will do this split soon for UNIX.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

wolfv commented 4 years ago

Ping @xhochy

wolfv commented 4 years ago

yes, sorry, i will fix that ASAP.