Recipe updates for cyclus release.

conda-forge / cyclus-feedstock

A conda-smithy repository for cyclus.

BSD 3-Clause "New" or "Revised" License

1 stars 14 forks source link

Recipe updates for cyclus release. #74

Closed munkm closed 5 months ago

munkm commented 6 months ago

I'm going to update the recipe slowly and see how well things go. This shouldn't be merged until we have a version and SHA we can reference in meta.yaml for the new version.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Old-style Python selectors (py27, py34, py35, py36) are deprecated. Instead, consider using the int py. For example: # [py>=36]. See lines [35, 36]
The boost-cpp output has been superseded by libboost-devel (as of 1.82), which now comes with a run-export (on libboost) as well. In case you only needed the boost headers, you should use libboost-headers.
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

munkm commented 6 months ago

@gonuke do we still need all of the flags (like https://github.com/conda-forge/cyclus-feedstock/blob/main/recipe/build.sh#L19) in the build.sh file? @bennibbelink says the default is now to build without coin so this flag seems a little redundant?

gonuke commented 6 months ago

Maybe we need to review when/if we build with/out COIN. I thought we did build with COIN in our CI builds.

gonuke commented 6 months ago

Or maybe I misunderstood this comment.... Since we are building with conda successfully in CI, I would recommend we use the same flags as the CI build in the Dockerfile... unless we think we want to deliver a different configuration for conda-forge?

munkm commented 6 months ago

I would recommend we use the same flags as the CI build in the Dockerfile... unless we think we want to deliver a different configuration for conda-forge?

It sounds reasonable to me to try to replicate what we have that's already successful. I can't currently think of a use case where we'd want a different option here than in the dockerfile.

munkm commented 5 months ago

Closing this in favor of https://github.com/conda-forge/cyclus-feedstock/pull/75