search

conda-forge / cyclus-feedstock

A conda-smithy repository for cyclus.
BSD 3-Clause "New" or "Revised" License
1 stars 14 forks source link

Rebuild for PyPy3.9 #77

Open regro-cf-autotick-bot opened 6 months ago

regro-cf-autotick-bot commented 6 months ago

This PR has been triggered in an effort to update pypy38.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8958888011 - please use this URL for debugging.

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bennibbelink commented 6 months ago

It is unclear to me whether we can use the Python C API with PyPy python. Looking into it.

EDIT: It does not appear that CPython and PyPy have the same C API. We will need to make some changes to cyclus/cyclus in order to support PyPy (specifically in PyHooks)

bam241 commented 6 months ago

@conda-forge-admin, please remove user @bam241

gonuke commented 6 months ago

It is unclear to me whether we can use the Python C API with PyPy python. Looking into it.

EDIT: It does not appear that CPython and PyPy have the same C API. We will need to make some changes to cyclus/cyclus in order to support PyPy (specifically in PyHooks)

I have no sense of what the benefits of this would be??

bennibbelink commented 6 months ago

Based on my brief research today:

PyPy is generally faster than CPython due to JIT compiler optimizations. Since our simulations are written primarily in C++ I (speculatively) doubt the performance would differ greatly.

I think a more valid argument for supporting PyPy is just to be compatible with the version of Python that users have. This is the first I have heard of PyPy (maybe you have a better idea), so I kind of doubt the demand is high for PyPy support. I propose we put this on the backlog of issues since it is probably not pressing (and might require fundamental changes to our use of the Python C API)