protobuf 3.15.* & version/build bump

conda-forge / cylc-flow-feedstock

A conda-smithy repository for cylc-flow.

BSD 3-Clause "New" or "Revised" License

3 stars 11 forks source link

protobuf 3.15.* & version/build bump #14

Closed dwsutherland closed 3 years ago

dwsutherland commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)

Corresponding change: https://github.com/cylc/cylc-flow/pull/4123

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

dwsutherland commented 3 years ago

Note: This PR hasn't updated the other dependencies (that may need changed for beta release).

kinow commented 3 years ago

Yes I think other deps will need to be changed too.

Ok with the proto change.

I think we need to hold off merging this because of the version change?

In part I think. If this PR is merged, it would use the new protobuf, but install Cylc Flow from commit 974480e2cee98071470ce8ca13eab600a32f213310b9fdc14a0b15ab6d50cb07 (in recipe). Not sure if that would work.

Besides, I think the cylc-feedstock wouldn't pick it. So users would have to manually install this build if they really wanted to use it (we had issues releasing last version, and locked on the build number https://github.com/conda-forge/cylc-feedstock/blob/c2e07f6e06fc4c19170959fb5053f54a12330508/recipe/meta.yaml#L24

hjoliver commented 3 years ago

Closing; cherry-picked to #15