Closed dwsutherland closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
Documentation on acceptable licenses can be found here.
Note: This PR hasn't updated the other dependencies (that may need changed for beta release).
Yes I think other deps will need to be changed too.
Ok with the proto change.
I think we need to hold off merging this because of the version change?
In part I think. If this PR is merged, it would use the new protobuf, but install Cylc Flow from commit 974480e2cee98071470ce8ca13eab600a32f213310b9fdc14a0b15ab6d50cb07
(in recipe). Not sure if that would work.
Besides, I think the cylc-feedstock
wouldn't pick it. So users would have to manually install this build if they really wanted to use it (we had issues releasing last version, and locked on the build number https://github.com/conda-forge/cylc-feedstock/blob/c2e07f6e06fc4c19170959fb5053f54a12330508/recipe/meta.yaml#L24
Closing; cherry-picked to #15
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Corresponding change: https://github.com/cylc/cylc-flow/pull/4123