Closed oliver-sanders closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@kinow could we rebuild the changes from https://github.com/conda-forge/cylc-flow-feedstock/pull/11 on the 8.0b2 release timeframe?
@kinow could we rebuild the changes from #11 on the 8.0b2 release timeframe?
I don't think so. That PR worked with Py 3.7 and 3.8 I think. But not 3.9. And I did my very shallow test, of using five
and some basic Cylc commands. I would be more confident if we had time to have someone like you or Hilary to play with the generated artifacts and see if there's nothing broken.
We can add for next beta or full release though.
(tests will fail until merged into release branch)
@conda-forge-admin, please restart ci
@conda-forge-admin, please rerender
Huh, dependency issues. I think I've had an issue like that. You should be able to build the recipe locally with a similar environment as conda and see what's causing the issue (I think there's a command to get conda to point to what appears to be broken).
Lots of conflict there, hard to tell the root cause(s), guesses:
rx
dep?Reproduced the issue locally with:
# activate conda
conda install conda-build
conda create -n test-cylc-flow
# debug really slows it down
conda build --use-local -c conda-forge --no-force-upload --debug --no-anaconda-upload ./recipe/
Will re-read your comment and try to understand what's going on in the morning :+1:
Some of the conda-environment
deps were pinned incorrectly - https://github.com/cylc/cylc-flow/pull/4340
That pandas<0.26
dep was particularly troublesome.
Currently trying out this diff:
diff --git a/recipe/meta.yaml b/recipe/meta.yaml
index 256515c..f911440 100644
--- a/recipe/meta.yaml
+++ b/recipe/meta.yaml
@@ -21,7 +21,7 @@ requirements:
run:
- aiofiles >=0.7.0,<0.8.0
- ansimarkup >=1.0.0
- - colorama >=0.4,<0.5
+ - colorama >=0.4,<1.0
- graphene >=2.1,<3
- jinja2 ==2.11.0,<2.12
- metomi-isodatetime >=1!2.0.2, <1!2.1.0
@@ -31,13 +31,12 @@ requirements:
- pyuv >=1.4.0,<1.5.0
- pyzmq >=19.0.0,<19.1.0
- setuptools >=49
- - urwid >=2.0,<2.1
+ - urwid >=2,<3
# TODO: optional dependencies, see discussion here https://github.com/conda-forge/cylc-flow-feedstock/pull/4
- empy >=3.3,<3.4
- - pandas >=0.25.0,<0.26
+ - pandas >=1.0
- pympler
- matplotlib-base
- - rx >=1.6,<2 # TODO: https://github.com/conda-forge/cylc-feedstock/pull/3#issuecomment-660716268
test:
imports:
That got it.
Includes:
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)