Closed MetRonnie closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge/cylc-flow are you still unsure about noarch?
@MetRonnie gotta rerender to actually effect changes, watch the tests go from 7 to 1 --- oops you only changed the top one.
@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/cylc-flow-feedstock/actions/runs/1664934934.
There is no reason this pkg isn't noarch. Please fix: add noarch designation to all outputs.
see my previous PR: https://github.com/conda-forge/cylc-flow-feedstock/pull/31
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/cylc-flow-feedstock/actions/runs/1664943888.
@conda-forge/cylc-flow are you still unsure about noarch?
After a chat with the conda-forge folks we think the _unix
psudo dependency will allow us to make Cylc a noarch package whilst disabling non-unix builds.
Addresses #30
Thanks @ngam for the tips, I am still new to conda-forge.
Note to self: https://conda.io/projects/conda-build/en/latest/resources/define-metadata.html#subpackage-requirements
@conda-forge-admin, please rerender
@conda-forge-admin, please rerender
Looks so much better now. Thanks @MetRonnie @oliver-sanders.
Watch out for some testing --- ideally, you should take test this pkg locally to ensure everything is fine (I am 99.9% sure it will be okay). You can safely ignore if people install it on Windows; they may get some errors about deps, etc., but that should be fine, nothing really to do with your package.
Also, you could fix https://github.com/conda-forge/cylc-flow-feedstock/issues/28 by removing the username and rerendering again. Maybe @MetRonnie should be added as well?
I've asked about removing maintainers on the conda-forge Gitter, I didn't get any definitive answer so in the absence of a documented route I guess we would just remove the entry from maintainers, re-render and hope for the best.
You can safely ignore if people install it on Windows
The whole __unix
thing should cause conda
to refuse to install on Windows due to unsatisfiable dependencies which saves the issue of broken builds 🤞.
I didn't get any definitive answer so in the absence of a documented route I guess we would just remove the entry from maintainers, re-render and hope for the best
Yes, this is the way to do it, imo. Also, you should fee
(Not merging in case you want to address the maintainer change here @MetRonnie, as suggested above).
@conda-forge-admin, please rerender
Going in...
Checklist
conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Use the
__unix
virtual package to try and enable noarch